Seperate Grant Flow #151
Seperate Grant Flow #151
Conversation
BurntNerve
commented
Apr 17, 2024
BurntNerve
commented
- Broke grant flow out into individual app.
- Streamlined dependencies by removing Next.js and Vercel dependencies
- Converted Next.js code to in-house hooks
- Converted Turbo bundler to Vite
- Reorganized code to handle lack of Next.js Page/Layout structure
🦋 Changeset detectedLatest commit: 958f66a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BurntNerve
force-pushed
the
nerve/grantRework
branch
from
81fcb0a to
41eda19
Compare
There was a problem hiding this comment.
Looks good to me. Approved but left a few comments that shouldn't block you but were items of interest.
Also along the lines of the exported icons, it might be worth it to try and limit fonts, or compress them because they can add up to be really heavy, but these are things we can always handle at a later point
| export { AvatarIcon } from "./Avatar"; | ||
| export { ChevronDownIcon } from "./ChevronDown"; | ||
| export { WalletIcon } from "./Wallet"; | ||
| export { CloseIcon } from "./Close"; |
There was a problem hiding this comment.
Worth to maybe have these in the ui package and pull them in from there..?
packages/constants/src/index.ts
Outdated
| @@ -89,7 +89,8 @@ export const testChainInfo: ChainInfo = { | |||
| // If mainnet chain-id/network changes be sure to update here. | |||
| const DASHBOARD_URLS = { | |||
| "xion-mainnet-1": "https://settings.burnt.com", | |||
| "xion-testnet-1": "https://testnet.settings.burnt.com", | |||
| // "xion-testnet-1": "https://testnet.settings.burnt.com", | |||
| "xion-testnet-1": "http://localhost:3000", | |||
There was a problem hiding this comment.
Did you forget to change this back?
