Skip to content
This repository has been archived by the owner on Mar 5, 2022. It is now read-only.

Version 4.0 (complete rewrite) #208

Open
11 of 14 tasks
burzum opened this issue Jul 14, 2020 · 3 comments
Open
11 of 14 tasks

Version 4.0 (complete rewrite) #208

burzum opened this issue Jul 14, 2020 · 3 comments

Comments

@burzum
Copy link
Owner

burzum commented Jul 14, 2020

⚠️ This is going to be a big BC breaker but it should be easy to write a migration for the existing data. ⚠️

The goal is to get rid of the thight coupling of the functionality of this plugin to the CakePHP framework. The internal coupling is bad and being tight bound to the framework causes more work than gaining a benefit from it. Then new version is going to use a framework agnostic library version of this plugin and is going to integrate it just very loose to Cake, so that future changes the framework is going to make wont' cause a lot work. However, I would recommend to use phauthentic/file-storage directly, you can already start to read the docs if you want. Experience has shown that all the plugins are just a PITA to maintain when CakePHP requires changes to the plugins, even inside minor releases.

The development work is done in the 4.0 branch https://github.com/burzum/cakephp-file-storage/tree/4.0

Todo:

  • Drop Gaufrette🗑️
  • Drop Imagine🗑️
  • Use CakePHP 4 🥳
  • Use php 7.4 🥳
  • Use phauthentic/file-storage (using Intervention Image and Flysystem) 🥳
  • Use phauthentic/file-storage-image-processor 🥳
  • Drop all the event listeners 🗑️
  • Total rewrite of the path builders (using phauthentic/file-storage)
  • Refactor the behavior and simplify it a lot
  • Refactor the helpers
  • Update the shells
  • Update tests
  • Tag stable releases of the phauthentic libraries
  • Update documentation - HELP WANTED AND APPRECIATED 🍻

Looking back at the old code makes me regretting not doing this cut earlier... 😟

@burzum burzum self-assigned this Jul 14, 2020
@burzum burzum changed the title Planing version 4.0 Version 4.0 (complete rewrite) Jul 16, 2020
@burzum
Copy link
Owner Author

burzum commented Nov 6, 2020

Just an update on this: Looks like we're going to get closer to tag a first stable release of the libs and finishing the sheels within the next few weeks. 🥳

@LordSimal
Copy link

I am curious how this rewrite is going and if I can somehow help

@burzum
Copy link
Owner Author

burzum commented Mar 3, 2021

@LordSimal you can give it a try it should work. Since I don't work with CakePHP anymore I can't say anything about how well it already works. I've also started in a new company and don't have time and mood for open source right now. It should work, there might be edge cases not being covered yet. @dereuromark is using it but I don't know about the current state.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants