updates related to cakephp core 4.0 release #203
Conversation
|
@burzum, please merge this PR and tag as 3.0.0 with release initial version? |
| { | ||
| if (!$this->_isFileUploadPresent($entity)) { | ||
| $event->stopPropagation(); | ||
|
|
||
| return; | ||
| return false; |
There was a problem hiding this comment.
Is this actually relevant? AFAIR Cake didn't bother about any return value from a callback like beforeSave()?
| @@ -98,12 +99,12 @@ public function beforeMarshal(Event $event, ArrayAccess $data): void | |||
| * @param \ArrayObject $options The options for the query | |||
| * @return void | |||
There was a problem hiding this comment.
You changed the return type but didn't update the doc block.
| @@ -80,7 +81,7 @@ public function __construct(array $properties = [], array $options = []) | |||
| * @link http://book.cakephp.org/3.0/en/orm/entities.html#accessors-mutators | |||
| * @return string | |||
| */ | |||
| protected function _getFullPath(): string | |||
| protected function _getFullPath() | |||
There was a problem hiding this comment.
Why did you remove the return type?
| @@ -91,7 +92,7 @@ protected function _getFullPath(): string | |||
| * @link http://book.cakephp.org/3.0/en/orm/entities.html#accessors-mutators | |||
| * @return string | |||
| */ | |||
| protected function _getUrl(): string | |||
| protected function _getUrl() | |||
There was a problem hiding this comment.
Why did you remove the return type?
| @@ -117,7 +118,7 @@ public function path(array $options = []): string | |||
| * @param array $options Path options. | |||
| * @return string | |||
| */ | |||
| public function url(array $options = []): string | |||
| public function url(array $options = []) | |||
There was a problem hiding this comment.
Why did you remove the return type?
| @@ -102,7 +103,7 @@ protected function _getUrl(): string | |||
| * @param array $options Path options. | |||
| * @return string | |||
| */ | |||
| public function path(array $options = []): string | |||
| public function path(array $options = []) | |||
There was a problem hiding this comment.
Why did you remove the return type?
| @@ -130,7 +131,7 @@ public function url(array $options = []): string | |||
| * @param array $options Path options. | |||
| * @return string | |||
| */ | |||
| protected function _path(array $options): string | |||
| protected function _path(array $options) | |||
There was a problem hiding this comment.
Why did you remove the return type?
|
@skie I've made a few comments and asked some questions. Can we discuss them so I can resolve the PR please? |
|
@skie any feedback on this? |
|
I would merge this PR as is. The types removed was autogenerated by external tool. |
|
@skie what tool? It sucks then. Use phpcs, phpstan and grumphp. |
|
@burzum It is rector. It works perfect if all docblock 100% correct and follow modern trends. |
|
@skie but removing the types here is plain wrong? |
|
I remember i had usecase which require this. I can remember what project it was but yes it was needed. |
|
@skie absolutely not. The only reason this is needed is an ancient php version that is > 7.0. The types are needed to merge this. |
|
Because of the author of this PR is not going to answer anymore I'm going to close this. This PR is going to be obsolete anyway in the near future when #208 is done. |
No description provided.