with types from DT

buschtoens · Jan 26, 2024 · 3fa23f4 · 3fa23f4
1 parent 3ae3b36
commit 3fa23f4
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -72,6 +72,7 @@ jobs:
           - ember-4.4
           - ember-4.8
           - ember-4.12
+          - ember-5.4
           - ember-release
           - ember-beta
           - ember-canary

diff --git a/test-app/config/ember-try.js b/test-app/config/ember-try.js
@@ -3,6 +3,20 @@
 const getChannelURL = require('ember-source-channel-url');
 const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
 
+const typesFromDefinitelyTyped = {
+  '@types/ember': '^4.0.10',
+  '@types/ember__application': '^4.0.10',
+  '@types/ember__debug': '^4.0.7',
+  '@types/ember__destroyable': '^4.0.4',
+  '@types/ember__helper': '^4.0.5',
+  '@types/ember__modifier': '^4.0.8',
+  '@types/ember__object': '^4.0.11',
+  '@types/ember__owner': '^4.0.8',
+  '@types/ember__routing': '^4.0.19',
+  '@types/ember__runloop': '^4.0.8',
+  '@types/ember__service': '^4.0.8'
+};
+
 module.exports = async function () {
   return {
     usePnpm: true,
@@ -14,23 +28,26 @@ module.exports = async function () {
             '@ember/test-helpers': '^2.9.3',
             'ember-cli': '^4.12.1',
             'ember-source': '~3.28.0',
-            'ember-qunit': '^6.2.0'
+            'ember-qunit': '^6.2.0',
+            ...typesFromDefinitelyTyped
           }
         }
       },
       {
         name: 'ember-4.4',
         npm: {
           devDependencies: {
-            'ember-source': '~4.4.0'
+            'ember-source': '~4.4.0',
+            ...typesFromDefinitelyTyped
           }
         }
       },
       {
         name: 'ember-4.8',
         npm: {
           devDependencies: {
-            'ember-source': '~4.8.0'
+            'ember-source': '~4.8.0',
+            ...typesFromDefinitelyTyped
           }
         }
       },
@@ -42,6 +59,14 @@ module.exports = async function () {
           }
         }
       },
+      {
+        name: 'ember-5.4',
+        npm: {
+          devDependencies: {
+            'ember-source': '~5.4.0'
+          }
+        }
+      },
       {
         name: 'ember-release',
         npm: {