Deprecations and TS Fixes

[gossi]

To prepare a v2.1 release as preparation to upgrade for v3 #744 :

• Deprecates <Link> component (in favor of (link) helper)
• Deprecates UILink class (in favor of only having a Link class)
• Fixes typescript issues Types are wrong - break with TS v4 #742 for type linting

[buschtoens]

I suspect that this will not actually work.

This addon has a build step that is executed before publishing to npm:

ember-link/package.json

Lines 28 to 29 in c8497dc

	"prepack": "ember ts:precompile",
	"postpack": "ember ts:clean",

This generates the respective .js and .d.ts files.

tsc does not include // @ts-* comments in the resulting .d.ts files:

import Transition from '@ember/routing/-private/transition';
import { Link } from 'ember-link';
export default class TestLink extends Link {
    isActive: boolean;
    isActiveWithoutQueryParams: boolean;
    isActiveWithoutModels: boolean;
    isEntering: boolean;
    isExiting: boolean;
    url: string;
    onTransitionTo?(): void;
    onReplaceWith?(): void;
    get qualifiedRouteName(): string;
    transitionTo(event?: Event): Transition;
    replaceWith(event?: Event): Transition;
    private _preventTransitionOut;
    private _createDummyTransition;
}

So those comments actually have no effect for users.

(FWIW this worked as a patch-package patch in our local repo, because we are depending on an older version that doesn't yet pre-compile.)

[buschtoens]

I'll try to think of a backwards-compatible fix.

[gossi]

Ah good point, I forgot about extraction steps in transpilation.

[gossi]

Woke up with a solution to the problem we discussed yesterday. Soooo java-ish ain't yet nobody will care 😂

[bertdeblock]

👋 When may we expect the v2.1 release?
I see the deprecation is already cleaned up on main, but AFAICT, it has not yet been released?

[gossi]

Exactly. I'm traveling and be back next week then I wanna do the release.

Unless ofc @buschtoens can do so and support hotfixes afterwards ;)

[bertdeblock]

Thanks @gossi!