Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @ember/test-helpers to v4 #832

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 3, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ember/test-helpers ^3.3.1 -> ^4.0.4 age adoption passing confidence
@ember/test-helpers ^2.9.3 || ^3.0.0 -> ^4.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file enhancement New feature or request internal labels Nov 3, 2024
@renovate renovate bot force-pushed the renovate/ember-test-helpers-4.x branch 16 times, most recently from 6be64bf to 95127e3 Compare November 9, 2024 19:12
@renovate renovate bot force-pushed the renovate/ember-test-helpers-4.x branch 5 times, most recently from 7b04887 to 604f11b Compare November 18, 2024 02:13
@renovate renovate bot force-pushed the renovate/ember-test-helpers-4.x branch from 604f11b to 4c5e6ff Compare November 18, 2024 03:52
@miguelcobain
Copy link

@buschtoens without this, people get

 WARN  Issues with peer dependencies found
.
└─┬ ember-link 3.3.0
  └── ✕ unmet peer @ember/test-helpers@"^2.9.3 || ^3.0.0": found 4.0.4

when installing

Should I file a PR to allow @ember/test-helpers ^2.9.3 || ^3.0.0 || ^4.0.0?

Copy link
Contributor Author

renovate bot commented Nov 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@buschtoens
Copy link
Owner

Thanks for the heads up, @miguelcobain! 🙇🏼

I've pushed 872e940 to this branch, applying your suggested fix.

Unfortunately I didn't get to work a lot with Ember in the past year, so I would like to defer the release coordination (and failing CI for ember-3.28 on main?) to @gossi, who graciously is co-owning this addon.

@buschtoens buschtoens merged commit 1cdb7d3 into main Nov 20, 2024
15 of 16 checks passed
@buschtoens buschtoens deleted the renovate/ember-test-helpers-4.x branch November 20, 2024 22:24
@miguelcobain
Copy link

Hey @gossi and @buschtoens. It's been a while now.
It would be great if we could get a patch release, please. 🙏

@gossi
Copy link
Collaborator

gossi commented Jan 14, 2025

unfortunately this PR broke CI. Can you take a look? Then we can release.

@miguelcobain
Copy link

@gossi can you point me to the failing GH action?
It seems like the latest run for the main branch was successful.

@gossi
Copy link
Collaborator

gossi commented Jan 14, 2025

ember-try was failing for v3.28: https://github.com/buschtoens/ember-link/actions/runs/11944245237/job/33400187719

GitHub
Link primitive to pass around self-contained route references. It's {{link-to}}, but better! - Repair docs (#854) · 460afcd

@miguelcobain
Copy link

@gossi please check the following PR: #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants