-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Dart 2.0 support #9
base: master
Are you sure you want to change the base?
Conversation
Hi @Stargator! Thank you so much for the work and contributions that you've done! I wasn't aware that my project had any current users until recently. I'll start up working on it again with ways that I have learned to write better code since the last commit. I'll start reviewing your pull request after work this afternoon. Please know that I greatly appreciate your efforts and that any comments that I make aren't detracting from that appreciation at all :) |
|
||
this._possibleFiles[urlData.path] = urlData.id; | ||
|
||
this._functionStore[urlData.id].listen((final dynamic httpRequest) async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a note here, too, to change supporting code so that this can be typed again in the parameter field under Dart 2.0.
@Stargator, I left some comments and praises in the GitHub review. Thanks again a million for the contributions! |
I'll review the pull requests in the other dependent packages as soon as I next can 👍 |
2b9e875
to
9e97979
Compare
@bwhite000 Ready for a re-review! |
9e97979
to
e53fdc8
Compare
@bwhite000 I have added a change that is based on a PR for dart2_constant. Those changes added |
e53fdc8
to
cfe6084
Compare
Nevermind, I removed those changes. I can incorporate it once dart2_constant is updated. |
cfe6084
to
7337172
Compare
@bwhite000 I set it up so web_server and cache both use my fork of dart2_constant. The package has been archived by the Dart Team. I'm hoping to convince them to let me be the primary maintainer. |
7337172
to
63119fd
Compare
@bwhite000 Are you able to review the changes I made to your feedback? Note that it is dependent on the other PRs in the original post being approved and merged for those dependent packages. |
@bwhite000 Do note, the Dart SDK has made changes to what kind of dependencies new versions of a package can have on pub.dev. See dart-lang/sdk#36765. From what I see, web-server and cache depend on my forked version of dart2_constant. So either:
|
Since this project provides the web_server executable, I need to update it for Dart 2.0
Dependent on the following PRs in other repos: