Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

oneof float support #106

Merged
merged 16 commits into from
Jun 11, 2020
Merged

oneof float support #106

merged 16 commits into from
Jun 11, 2020
+1,443 −28

Conversation

andrew-werdna
Copy link
Contributor

@andrew-werdna andrew-werdna commented Jun 9, 2020 •
edited by bxcodec
Loading

  • add support for float32
  • ensure support for both float32 and float64
  • lint fixes
  • add tests for float64 & add test for nil pointer""

fix #82

@andrew-werdna
add support for float32
67af8c5 
ensure support for both float32 and float64

lint fixes

add tests for float64 & add test for nil pointer
@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #106 into master will increase coverage by 0.75%.
The diff coverage is 98.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   94.95%   95.71%   +0.75%     
==========================================
  Files          10       11       +1     
  Lines        1050     1236     +186     
==========================================
+ Hits          997     1183     +186     
- Misses         29       30       +1     
+ Partials       24       23       -1
Impacted Files Coverage Δ
faker.go 91.89% <96.82%> (+0.87%) ⬆️
tag_argument_extractor.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463a71e...94ceac2. Read the comment docs.

@andrew-werdna
Copy link
Contributor Author

@bxcodec I got bored haha. I decided to jump in sooner rather than later with support for the float types.

@andrew-werdna
Copy link
Contributor Author

Once this is merged, it should really close #82

bxcodec
bxcodec reviewed Jun 10, 2020
View reviewed changes
faker.go Outdated Show resolved Hide resolved
@bxcodec
Copy link
Owner

bxcodec commented Jun 10, 2020

Once this is merged, it should really close #82

thanks, added the fix keyword on the PR desc so it will automatically close the issue once this PR is merged

@andrew-werdna
Copy link
Contributor Author

@bxcodec I followed your suggestion and used ParseUint for the unsigned int types.

@andrew-werdna
Copy link
Contributor Author

Something I just thought of (I don't know how I missed it before), but support could be added (perhaps in another PR), for the parsing of binary, hex etc into the different int types

@andrew-werdna
Copy link
Contributor Author

I have an idea on how I can clean this up a little bit. Let me make this WIP again and I can do some clean up.

@andrew-werdna andrew-werdna changed the title oneof float support WIP: oneof float support Jun 10, 2020
@andrew-werdna andrew-werdna changed the title WIP: oneof float support oneof float support Jun 10, 2020
@andrew-werdna andrew-werdna requested a review from bxcodec June 11, 2020 00:46
@andrew-werdna
Copy link
Contributor Author

@bxcodec okay I think it is now ready for review again! 👍

bxcodec
bxcodec reviewed Jun 11, 2020
View reviewed changes
tag_argument_extractor.go Outdated Show resolved Hide resolved
bxcodec
bxcodec approved these changes Jun 11, 2020
View reviewed changes
Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's think about that later for the hex/binary/etc

Thanks for your PR bro 🙏

@bxcodec bxcodec merged commit 2a46c04 into bxcodec:master Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bxcodec bxcodec bxcodec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bool values or OneOf
2 participants
@andrew-werdna @bxcodec