Merge branch 'vilayat/task/graceful-shutdown' of https://github.com/b…

…ytebeamio/uplink into vilayat/task/re-read-packets
bytebeamio · Nov 1, 2023 · cb9e756 · cb9e756
2 parents 1dda22a + 0b6f214
commit cb9e756
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 100 deletions.
diff --git a/config.toml b/config.toml
diff --git a/notes.md b/notes.md
diff --git a/qa-scripts/.env b/qa-scripts/.env
@@ -1,3 +1,3 @@
-CONSOLED_DOMAIN=stage.bytebeam.io
-BYTEBEAM_API_KEY=b027b7ab-b294-4ff7-a197-d47e38e55bd1
-DEVICE_ID=1001
+CONSOLED_DOMAIN=
+BYTEBEAM_API_KEY=
+DEVICE_ID=
diff --git a/qa-scripts/actions.sh b/qa-scripts/actions.sh
@@ -22,7 +22,7 @@ port = 7891
 actions = [{ name = "no_response", timeout = 100 }, { name = "restart_response", timeout = 1800 }]
 EOF
 )" > devices/actions.toml
-# docker cp devices/actions.toml simulator:/usr/share/bytebeam/uplink/devices/actions.toml
+docker cp devices/actions.toml simulator:/usr/share/bytebeam/uplink/devices/actions.toml
 
 docker exec -it simulator uplink -a /usr/share/bytebeam/uplink/devices/device_$DEVICE_ID.json -c /usr/share/bytebeam/uplink/devices/actions.toml -vv -m uplink::base::bridge
 

diff --git a/questions.md b/questions.md
diff --git a/ssl.json b/ssl.json
diff --git a/uplink/src/base/bridge/mod.rs b/uplink/src/base/bridge/mod.rs
@@ -145,14 +145,4 @@ impl BridgeTx {
             }
         });
     }
-
-    /*
-    TODO:
-
-    Description: Shutdown MQTT connection with broker when getting signals for exit/quit
-
-    Create a directory inside the persistence directory
-    - save inflight data packets
-
-     */
 }
diff --git a/uplink/src/main.rs b/uplink/src/main.rs
@@ -195,8 +195,6 @@ fn main() -> Result<(), Error> {
             while let Some(signal) = signals.next().await {
                 match signal {
                     SIGTERM | SIGINT | SIGQUIT => bridge_tx.trigger_shutdown().await,
-                    // how to insert graceful shutdown code?
-                    // it is partially there... need to add from here
                     s => error!("Couldn't handle signal: {s}"),
                 }
             }