refactor: remove timeout information from apps #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
commented
Oct 7, 2023
tekjar
reviewed
Oct 13, 2023
tekjar
approved these changes
Oct 13, 2023
This reverts commit e9aac6d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes
Why?
To remove/cleanup unnecessary code for handling timeout from app side.
Trials Performed
Run uplink as usual but with an action of extremely short duration, send an action that it is configured to handle, no change in uplink behavior observed. Action still timedout when not responded to and the app stopped processing action on timeout.