Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: action cancellation #339

Merged
merged 27 commits into from
May 27, 2024
Merged

feat: action cancellation #339

merged 27 commits into from
May 27, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Apr 4, 2024

Closes #

Changes

Action mid execution should be cancellable at one of two places:

  1. During execution in a preemptable stage, e.g. while downloading a file(should also delete file created as a result of partial download)
  2. At the end of a non-preemptable stage, e.g. at the end of a system-update, but before a restart sequence that would apply the update, this allows the customer to tunshell into the device and make any revertions necessary, but this is just an example and needs more thinking.

As an example of how this can be configured at the application level, downloader is the first built-in to support cancellation, as part of the cancellation procedure, it will also delete a partially downloaded file.

Why?

Trials Performed

Awaiting backend support for testing

@de-sh de-sh marked this pull request as ready for review May 3, 2024 07:04
@de-sh de-sh merged commit 10e5dc2 into main May 27, 2024
2 checks passed
@de-sh de-sh deleted the cancellation branch May 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant