Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic on transform stream check #143

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: panic on transform stream check #143

merged 1 commit into from
Sep 10, 2024

Conversation

guybedford
Copy link
Contributor

This fixes a panic Fastly was seeing when passing a request body to a response, where this slot was not a boolean causing a panic.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems locally fine as a more robust check, but do we know why the slot was not a boolean? Is there a path that doesn't initialize it, or is some other value being stored there erroneously?

@guybedford
Copy link
Contributor Author

There's a lot of complex logic here and quite honestly I haven't traced it carefully, but I can verify this solves the full end to end Fastly issue in fastly/js-compute-runtime#954.

@guybedford guybedford merged commit ba37afe into main Sep 10, 2024
4 checks passed
@guybedford guybedford deleted the transform-panic branch September 10, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants