TLA #28
Merged
TLA #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
tla
branch
2 times, most recently
from
5902b1e
to
94ca72d
Compare
tschneidereit
requested changes
Apr 18, 2024
|
Oops, hit the button without leaving a comment. This looks really great, thank you! I requested a few changes, but I think they should all be fairly minor. |
Signed-off-by: Guy Bedford <[email protected]>
Signed-off-by: Guy Bedford <[email protected]>
Co-authored-by: Till Schneidereit <[email protected]>
tschneidereit
approved these changes
Apr 19, 2024
runtime/js.cpp
Outdated
| @@ -42,16 +42,16 @@ bool initialize(const char *filename) { | |||
|
|
|||
| RootedValue result(engine.cx()); | |||
| bool success = engine.eval_toplevel(filename, &result); | |||
| success = success && engine.run_event_loop(&result); | |||
| success = success && engine.run_event_loop(); | |||
There was a problem hiding this comment.
This turns out to be redundant, because eval_toplevel always spins the event loop (with or without this PR), so let's just remove it.
Suggested change
| success = success && engine.run_event_loop(); |
There was a problem hiding this comment.
Sure, nice to clean this up. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for TLA with some basic tests, resolving #14.
There is still work to do on improving errors and unhandled rejections.
Also expands the test suite to better support error output testing to enable these follow-ups.
Note, this requires #25 to land first for CI to pass.