Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extension searching #29

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

guybedford
Copy link
Contributor

Adds simple support for extension searching in imports.

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I guess we'll at some point want to do something more fully-fledged, including supporting .jsm and module path searches, but all of that should be fully backwards compatible with this.

@guybedford
Copy link
Contributor Author

Yes, we should support the full Node.js algorithm here, and we can get there. Extension searching is strictly speaking not part of the modern Node.js resolution, but it's common enough in bundlers that it is worth enabling. It likely makes sense to disable it then in a breaking change eventually though, once enough of the JS ecosystem is no longer using extension searching.

@guybedford guybedford merged commit 073e7bb into bytecodealliance:main Apr 17, 2024
1 check passed
@guybedford guybedford deleted the extension-searching branch April 17, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants