Support builtin modules #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While we still don't have tests of building builtins, this is a little tricky to get coverage on, but I can confirm that it is working in my work-in-progress branch to support Fastly builtins. |
guybedford
force-pushed
the
define-builtins
branch
2 times, most recently
from
aaf91d2
to
d0acb1d
Compare
guybedford
commented
Apr 19, 2024
guybedford
commented
Apr 19, 2024
guybedford
commented
Apr 19, 2024
include/extension-api.h
Outdated
| * | ||
| * Once loaded, the instance is cached and reused as a singleton. | ||
| */ | ||
| bool define_builtin_import(const char* id, HandleValue builtin); |
There was a problem hiding this comment.
An example usage here might look like:
define_builtin_import("fastly:env", envObject);
guybedford
force-pushed
the
define-builtins
branch
from
d0acb1d
to
2f8019f
Compare
tschneidereit
approved these changes
Apr 25, 2024
Comment on lines
+162
to
+166
| if (firstValue) { | ||
| firstValue = false; | ||
| } else { | ||
| code += ", "; | ||
| } |
There was a problem hiding this comment.
Not at all important, but I think it'd be fine to append the , unconditionally, and then just remove the leading space before the closing }.
There was a problem hiding this comment.
Yeah agreed, although I still prefer the proper formatting I must admit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for defining builtin modules from JS objects, which are then lazily turned into synthetic modules when imported, based on enumerating the own keys of the object and making those the exports of the synthetic module.
Useful for supporting custom internal APIs without needing to define globals.