Change poll's timeout from c_int to Option<&Timespec>.
#1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This harmonizes the timeout with the rest of rustix, which uses `Timespec` for all time values. And, it eliminates the awkwardness of using `-1` as a sentinel value. On platforms with `ppoll`, the `Timespec` can be passed straight to the OS. On platforms without `ppoll`, we have to do a fallible conversion into `c_int`.
sunfishcode
force-pushed
the
sunfishcode/poll-timeout
branch
from
80fbb61 to
5be3893
Compare
|
Will take a look sometime this week. |
SUPERCILEX
approved these changes
Feb 1, 2025
| } | ||
| secs.checked_mul(1000) | ||
| .and_then(|millis| { | ||
| millis.checked_add((i64::from(timeout.tv_nsec) + 999_999) / 1_000_000) |
There was a problem hiding this comment.
Can we add a comment that says the purpose of this is to round up to the nearest millisecond?
There was a problem hiding this comment.
Sweet, this looks amazing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This harmonizes the timeout with the rest of rustix, which uses
Timespecfor all time values. And, it eliminates the awkwardness of using-1as a sentinel value.On platforms with
ppoll, theTimespeccan be passed straight to the OS. On platforms withoutppoll, we have to do a fallible conversion intoc_int.