Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return PID from waitpid #996

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Return PID from waitpid #996

merged 1 commit into from
Jan 20, 2024

Conversation

SUPERCILEX
Copy link
Contributor

Fixes #989

sunfishcode
sunfishcode reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment:

tests/process/wait.rs Outdated Show resolved Hide resolved
@sunfishcode
Copy link
Member

Also, those CI errors look unrelated, so don't worry about those; I'll fix those separately.

@sunfishcode sunfishcode added the semver bump Issues that will require a semver-incompatible fix label Jan 19, 2024
@SUPERCILEX
Return PID from waitpid
ff80bc3 
Signed-off-by: Alex Saveau <[email protected]>
@sunfishcode sunfishcode merged commit 1efd93c into bytecodealliance:1.0-staging Jan 20, 2024
10 of 44 checks passed
@sunfishcode
Copy link
Member

Thanks!

@SUPERCILEX SUPERCILEX mentioned this pull request Aug 14, 2024
Closed
sunfishcode pushed a commit that referenced this pull request Aug 15, 2024
@SUPERCILEX @sunfishcode
Return PID from waitpid (#996)
9892c61 
Signed-off-by: Alex Saveau <[email protected]>
sunfishcode pushed a commit that referenced this pull request Aug 26, 2024
@SUPERCILEX @sunfishcode
Return PID from waitpid (#996)
c5529aa 
Signed-off-by: Alex Saveau <[email protected]>
sunfishcode pushed a commit that referenced this pull request Sep 5, 2024
@SUPERCILEX @sunfishcode
Return PID from waitpid (#996)
cefdb10 
Signed-off-by: Alex Saveau <[email protected]>
sunfishcode pushed a commit that referenced this pull request Sep 5, 2024
@SUPERCILEX @sunfishcode
Return PID from waitpid (#996)
ba0947f 
Signed-off-by: Alex Saveau <[email protected]>
@sunfishcode sunfishcode mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode left review comments

Assignees
No one assigned
Labels
semver bump Issues that will require a semver-incompatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SUPERCILEX @sunfishcode