-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple config command just for setting default registry #100
Conversation
I'd maybe make the flag name a little more explicit, e.g. |
Two possible follow-up features that I think would have a good bang-for-buck:
|
Thanks for the recommendations, @lann . I will update shortly. |
…launch default editor
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to go from my side. Mostly comments/nits that don't necessarily need to be addressed before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot - forgot to submit review. Not super critical but these comments do show up in --help
.
Co-authored-by: Lann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just a bare minimum config subcommand for setting the default registry.
wkg config
prints current default registrywkg config --default-registry {REGISTRY}
sets the default registrywkg config --edit
launches editor ($EDITOR
env var) with the config fileCan follow up with an addition PR for other config options.