-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable warnings if gc
is disabled
#10149
Enable warnings if gc
is disabled
#10149
Conversation
Continuation of work in bytecodealliance#10131. This additionally handles turning off `gc-null` and `gc-drc` and the various combinations within.
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:ref-types"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
#[cfg(feature = "gc")] | ||
use crate::runtime::vm::GcRootsList; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you wanted to fully qualify these at the use site?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there are multiple uses in this module or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally yeah I generally prefer avoiding #[cfg]
on imports since it feels pretty noisy, but this one was used so much it was getting even noisier to have fully qualified use-sites.
Probably an indicator to create crates/wasmtime/src/runtime/store/gc.rs
perhaps...
Continuation of work in #10131. This additionally handles turning off
gc-null
andgc-drc
and the various combinations within.