update ittapi to 0.4.0 #7337
Merged
update ittapi to 0.4.0 #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulchaphalkar
requested review from
alexcrichton
and removed request for
a team
alexcrichton
requested review from
abrown
and removed request for
alexcrichton
|
Thanks! Looks good to me, but I'd like to double-check with @abrown as well |
abrown
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Yup, @rahulchaphalkar and I worked together to get this fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the JIT Code visibility issue for VTune. Tested wasmtime cli with a simple Fibonacci fib.wasm file, and can see the following with vtune hotspots -
Previously this was [Outside Any Module] along with trace file corruption log in vtune.
This change enables vtune profiler to be used for wasm code hotspots, microarchitecture analysis, disassembly viewing etc.
Fixes issues like this #5628
Ittapi change which fixes the issue is here intel/ittapi#105