-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance measuring accuracy #2
base: master
Are you sure you want to change the base?
Conversation
There is a memory leak in the error path of trace_irqoff_init(), so fix it properly. Signed-off-by: Chengguang Xu <[email protected]>
In order to enhance measuring accuracy, we use tasklet instead of timer in the case of detecting softirq off. Signed-off-by: Chengguang Xu <[email protected]>
The timer is implemented base on the softirq. The |
It looks like that we can make the code simply. Right? |
Yes, two approaches are very similar. However, I think timer depends HZ |
hmm, maybe. The only concern is that tasklet approach may sightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems no memleak. What I missed?
It seems to forget releasing percpu val in error case, Am I missing something? |
Great. I see now. Thanks. Can you split those 2 commits to 2 mr? So that I can |
Sure, will update shortly. |
I've made new PR for memory leak, I'll make another PR after that get merged. |
So is there a plan to apply this change in the future? |
In order to enhance measuring accuracy, we use tasklet
instead of timer in the case of detecting softirq off.
Meanwhile, fix a memleak in error path.