Skip to content

Commit

Permalink
Accessibility tweaks/Release v1.3.7 (#481)
Browse files Browse the repository at this point in the history
* Fix footer general link focus

* Fix action button styles.

* Run build

* Update version

* Run build
  • Loading branch information
Blake Morgan authored Jul 30, 2020
1 parent 4120d09 commit 35343bd
Show file tree
Hide file tree
Showing 24 changed files with 107 additions and 97 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,12 @@
text-decoration: none !important;
}

@mixin footerActionButtonSlottedLinkFocus() {
outline: solid 2px white !important;
}

@mixin mobileFooterActionButton() {
padding: 6.5px 0;
font-size: 11px;
line-height: 13px;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@ byu-footer-action-button:not(.byu-component-rendered) > * {
//byu-footer-action-button:not(:defined) a {
byu-footer-action-button:not(.byu-component-rendered) a {
@include footerActionButtonSlottedLink();
}
}

byu-footer-action-button:not(.byu-component-rendered) a:focus {
@include footerActionButtonSlottedLinkFocus();
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,8 @@

.wrapper ::slotted(a) {
@include footerActionButtonSlottedLink();
}
}

.wrapper ::slotted(a:focus) {
@include footerActionButtonSlottedLinkFocus();
}
4 changes: 4 additions & 0 deletions components/byu-footer-column/byu-footer-column-common.scss
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,7 @@
@mixin defaultContentLinkHover() {
color: $navy !important;
}

@mixin defaultContentLinkFocus() {
outline: solid 2px $royal !important;
}
10 changes: 9 additions & 1 deletion components/byu-footer-column/byu-footer-column-extras.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ byu-footer-column:not(.byu-component-rendered) {
#defaultContent a:hover {
@include defaultContentLinkHover();
}

#defaultContent a:focus {
@include defaultContentLinkFocus();
}
}

byu-footer-column:not(.byu-component-rendered) [slot="header"] {
Expand Down Expand Up @@ -56,6 +60,10 @@ byu-footer-column a:hover {
@include defaultContentLinkHover();
}

byu-footer-column a:focus {
@include defaultContentLinkFocus();
}

@media (max-width: 1024px) {
byu-footer-column a {
@include mobileContentLink();
Expand All @@ -80,4 +88,4 @@ byu-footer-column a:hover {
font-size: 12px !important;
}

}
}
13 changes: 10 additions & 3 deletions components/byu-footer-column/byu-footer-column.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
@include defaultContentLinkHover();
}

.content ::slotted(a:focus) {
@include defaultContentLinkFocus();
}

.content > a {
@include defaultContentLink();
}
Expand All @@ -50,14 +54,17 @@
@include defaultContentLinkHover();
}

.content > a:focus {
@include defaultContentLinkFocus();
}

@media (max-width: 1024px) {
.content {
::slotted(:not(byu-footer-action-button)) {
@include mobileContentNotButton();
}

}
}
.header ::slotted(*) {
@include mobileHeaderSlotted();
}
}
}
2 changes: 1 addition & 1 deletion dist/2017-core-components.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/2017-core-components.min.js.map

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion dist/byu-theme-components.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/byu-theme-components.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/byu-theme-components.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/byu-theme-components.min.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/byu-theme-components.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 35343bd

Please sign in to comment.