Update Usage #5
Open
Update Usage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage: fluidsynth [options] [soundfonts] [midifiles] If we use the old one，we will see: Parameter '-F' not a SoundFont or MIDI file or error occurred identifying it. Parameter 'output.wav' not a SoundFont or MIDI file or error occurred identifying it. Parameter '-r' not a SoundFont or MIDI file or error occurred identifying it. Parameter '44100' not a SoundFont or MIDI file or error occurred identifying it. Now, [options] are on the front
1 Modify the code to adapt to the new version, The reason is in README Commit changes 2 Format code
bzamecnik
reviewed
Sep 27, 2022
| default=DEFAULT_SOUND_FONT, | ||
| help='path to a SF2 sound font (default: %s)' % DEFAULT_SOUND_FONT) | ||
| default=DEFAULT_SOUND_FONT, | ||
| help='path to a SF2 sound font (default: {})'.format(DEFAULT_SOUND_FONT)) |
There was a problem hiding this comment.
These changes are unrelated, should not be in the commit.
bzamecnik
reviewed
Sep 27, 2022
| class FluidSynth(): | ||
| def __init__(self, sound_font=DEFAULT_SOUND_FONT, sample_rate=DEFAULT_SAMPLE_RATE): | ||
| self.sample_rate = sample_rate | ||
| self.sound_font = os.path.expanduser(sound_font) | ||
|
|
||
| def midi_to_audio(self, midi_file, audio_file): | ||
| subprocess.call(['fluidsynth', '-ni', self.sound_font, midi_file, '-F', audio_file, '-r', str(self.sample_rate)]) | ||
| subprocess.call(['fluidsynth', '-ni', '-F', audio_file, '-r', str(self.sample_rate), |
There was a problem hiding this comment.
Did the behavior of fluidsynth change? In which version? Did you make any tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
fluidsynth [options] [soundfonts] [midifiles]
If we use the old one，we will see:
Parameter '-F' not a SoundFont or MIDI file or error occurred identifying it.
Parameter 'output.wav' not a SoundFont or MIDI file or error occurred identifying it.
Parameter '-r' not a SoundFont or MIDI file or error occurred identifying it.
Parameter '44100' not a SoundFont or MIDI file or error occurred identifying it.
Now, [options] are on the front
Use "fluidsynth -ni -F output.wav -r 44100 sound_font.sf2 input.mid"