Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error for GL_VERSION 43+ caused by shadowing of debugMessageCallback #21

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

SadeAli
Copy link
Contributor

@SadeAli SadeAli commented Sep 10, 2024

Fixed a compile error that occurred when using "GL_VERSION = 43" and higher due to the shadowing of the "debugMessageCallback" function. The function was declared both in the general OpenGL module and in the OpenGL 4.3+ version-specific modules, causing a conflict. Removed the redundant declaration from the general module, as this callback is only relevant for OpenGL 4.3 and above.

Compiling versions lower than 4.3 works without this fix.

Tested the solution with GL_VERSION = [31, 32, 33, 40, 41, 42, 43, 44, 45, 46]. No issues detected.

…ageCallback

Fixed a compile error that occurred when using "GL_VERSION = 43" and higher due to the shadowing of the "debugMessageCallback" function. The function was declared both in the general OpenGL module and in the OpenGL 4.3+ version-specific modules, causing a conflict. Removed the redundant declaration from the general module, as this callback is only relevant for OpenGL 4.3 and above.

Compiling versions lower than 4.3 works without this fix.

Tested the solution with GL_VERSION = [31, 32, 33, 40, 41, 42, 43, 44, 45, 46]. No issues detected.
@SadeAli SadeAli changed the title Fix compile error for GL_VERSION 43+ caused by shadowing of … Fix compile error for GL_VERSION 43+ caused by shadowing of debugMessageCallback Sep 10, 2024
@lerno
Copy link
Contributor

lerno commented Sep 10, 2024

Thank you!

@lerno lerno merged commit adef778 into c3lang:main Sep 10, 2024
1 check passed
@SadeAli SadeAli deleted the patch-1 branch September 10, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants