restructure convertfunctions #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mxmxchere
commented
May 6, 2024
mxmxchere
commented
- Restructure README.md
- All convertmethods with none-function
- Tiny steps to use convertfunctions via an interface
- Some stuff that should have happened earlier...
- New type for mqtt payload in test
- Removes mockup _test files
- Second convertmode in new interface format
- Remove convertfunctions.go and fix log message
- Implemented convertmode uint82ascii
- Generic implementation for all uint*2ascii convertmodes
- Enable uint*2ascii convertmodes
- Adds new interfaced convertmode 2uint322ascii
- Implement all uint convertmodes
- Convert modes of uint and int now en par
- New convertmode in interfaced-form bytecolor2colorcode
- Last convertmode implemented
- Removes helpers.go
- Adds e2e test state
- Updates readme
added 19 commits
April 28, 2024 14:38
* convertmodes are now in a table * first steps to restructure convertmodes to external files, a cleaner interface Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
* Changed the default type for CAN-IDs to uint32 in all places * Changed the default type for MQTT Payload to []byte * Completely removed convert2CAN and convert2MQTT functions
Signed-off-by: Malte Muench <[email protected]>
Placed hint for myself to use strings.Fields instead of split
Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
Signed-off-by: Malte Muench <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.