Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/granular dashboards #28

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Feat/granular dashboards #28

merged 3 commits into from
Jan 10, 2025

Conversation

puffitos
Copy link
Member

@puffitos puffitos commented Jan 10, 2025

Motivation

Implements #25

Not all dashboards are always needed; for example, a cluster may not have longhorn installed or the performance dashboards make no sense in a downstream cluster, as noted in the issue.

Changes

  • Split up the configmap dashboard file into multiple files
  • Added value toggles to activate/deactivate dashboards

Tests done

All active

Deployed a version with the standard values, all dashboards are present again:

image

I'll do another test with the performance dashboards deactivated (and all others as well) to see how helm and our grafana reacts.

Rancher Performance deactivated

Changes the values to:

caas:
  grafana:
    dashboards:
      rancherPerformance: false

The configmap was removed and grafana sucessfully refreshed the dashbhoards. No more rancher perfomance:

image

All rancher dashboards gone

Updated the values to:

caas:
  grafana:
    dashboards:
      nginxIngress: false
      rancherCluster: false
      rancherHome: false
      rancherK8sComponents: false
      rancherNodes: false
      rancherPerformance: false
      rancherPods: false
      rancherWorkloads: false
      longhorn: false

and, as expected, the dashboards were also removed from grafana:

image

The default grafana dashboards can be activated/deactivated now. This will allow the
chart to be shipped with additional dashboards which only make sense in a rancher upstream cluster,
like the performance ones.

Signed-off-by: Bruno Bressi <[email protected]>
@puffitos puffitos added enhancement New feature or request area/dashboards Issues and PRs regarding the grafana dashboards shipped with the chart. labels Jan 10, 2025
@puffitos puffitos added this to the 1.0.0 milestone Jan 10, 2025
@puffitos puffitos self-assigned this Jan 10, 2025
Comment on lines -17 to -18
grafana:
configmaps: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, this value wasn't used anymore 🤷

@puffitos puffitos merged commit df4bf10 into main Jan 10, 2025
1 check passed
@puffitos puffitos deleted the feat/granular-dashboards branch January 10, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboards Issues and PRs regarding the grafana dashboards shipped with the chart. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants