fix: remove multiple registered domain for TLS managed certificates #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 37.08% 42.19% +5.10%
==========================================
Files 12 12
Lines 364 365 +1
==========================================
+ Hits 135 154 +19
+ Misses 228 210 -18
Partials 1 1
☔ View full report in Codecov by Sentry. |
Embraser01
approved these changes
Nov 5, 2023
mavimo
force-pushed
the
fix-remove-multiple-registered-domain-for-tls-managed-certificates
branch
from
68a01e9 to
6bc4dd9
Compare
mavimo
deleted the
fix-remove-multiple-registered-domain-for-tls-managed-certificates
branch
mavimo
added a commit
to Xinayder/caddy-ingress-controller
that referenced
this pull request
Nov 7, 2023
…addyserver#173) * fix: add tests for TLS plugin * fix: do not register the same host multiple times in TLS plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the code review for the contribution #133 when added test we notice that we register the same domain multiple time, this PR add test to cover the TLS plugin and fix the underground problem.