Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the go version to 1.22 #223

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore: Update the go version to 1.22 #223

merged 1 commit into from
Apr 29, 2024

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Apr 29, 2024

No description provided.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.90%. Comparing base (d4af4bc) to head (b323066).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #223       +/-   ##
===========================================
- Coverage   45.65%   18.90%   -26.75%     
===========================================
  Files          17       30       +13     
  Lines         414     1063      +649     
===========================================
+ Hits          189      201       +12     
- Misses        224      861      +637     
  Partials        1        1               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavimo mavimo enabled auto-merge (squash) April 29, 2024 20:05
@mavimo
Copy link
Member Author

mavimo commented Apr 29, 2024

NB: coverage decrease as in Go 1.22 the file without coverage are now reported as 0% coverage instead of being skipped.

@mavimo mavimo requested review from mholt and Embraser01 April 29, 2024 20:06
@mavimo mavimo self-assigned this Apr 29, 2024
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer Go sounds great to me!

@mavimo mavimo merged commit a2bf1c3 into main Apr 29, 2024
3 of 4 checks passed
@mavimo mavimo deleted the update-go-version branch April 29, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants