Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for event_handlers #1404

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

3vilhamster
Copy link
Member

What changed?
Added a couple of unit tests for internal event_handlers and removed unused method.

Why?
Improving code coverage to be above the bar.

How did you test it?

Potential risks

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.52%. Comparing base (06afa1f) to head (045df16).
Report is 1 commits behind head on master.

Files with missing lines Coverage Δ
internal/internal_event_handlers.go 70.94% <ø> (+3.25%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06afa1f...045df16. Read the comment docs.


🚨 Try these New Features:

@3vilhamster 3vilhamster merged commit fabd87b into cadence-workflow:master Nov 21, 2024
10 checks passed
@3vilhamster 3vilhamster deleted the more-unit-tests branch November 21, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants