Add variable to support prefixPath for the cadence web-UI #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Assem-Uber
requested changes
May 29, 2024
There was a problem hiding this comment.
Also tested the changes and had few extra comments there:
- The development environment is not working with the prefix
- The clicking on the logo doesn't take you back to the origin with the prefix
- The prefix is not considered on all places, example:
https://github.com/uber/cadence-web/blob/master/server/index.js#L138
https://github.com/uber/cadence-web/blob/master/client/containers/domain/actions.js#L69
| const prefixPath = process.env.PREFIX_PATH; | ||
|
|
||
| if (!origin.endsWith(prefixPath)) { | ||
| origin = `${origin}${prefixPath}`.replace(/\/$/, ''); |
There was a problem hiding this comment.
adding path to origin is misleading, managing the path is more accurate
| const app = new Koa(); | ||
| const appPrefixPath = process.env.PREFIX_PATH || '/' | ||
|
|
||
| app.use(mount(appPrefixPath, cadenceWeb.init())); |
There was a problem hiding this comment.
This middleware needs to get added inside server/index and used as part of the app init. The server/index acts as the entrypoint if you are installing cadence-web as a dependency package. (more about it here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new PREFIX_PATH variable to enable hosting cadence-web at some base URL prefix path.
This variable needs to be injected during build time and runtime as well since client code also needs it.
Ex. I can build cadence-web using the command below.
Then I can define environment variable during runtime.
If
PREFIX_PATHis not defined during build and runtime, cadence-web would be running at/root path by default.