Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Allow varc to output as tar.lz4 #21

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Allow varc to output as tar.lz4 #21

merged 6 commits into from
Sep 20, 2024

Conversation

john-cado
Copy link
Contributor

Compressing with .tar.lz4 is significantly faster than zip (at the cost of slightly less compression). Changes in this PR:

  • Move handling for output_path into the init instead of mutating state in acquire_volatile
  • Replace open entry and writing string to it with writestr
  • Create a wrapper around tar and lz4 with limited part of ZipFile interface and use depending on output path extension

@chrisdoman chrisdoman closed this Sep 20, 2024
@chrisdoman chrisdoman reopened this Sep 20, 2024
@john-cado john-cado merged commit b8102a9 into cado-security:main Sep 20, 2024
12 of 16 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@p-s-cott p-s-cott p-s-cott approved these changes

@cadosecurity cadosecurity Awaiting requested review from cadosecurity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-cado @p-s-cott @chrisdoman