Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more compression options (DictionarySize, SortFilesByType) #296

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

stehlih
Copy link
Contributor

@stehlih stehlih commented Jan 14, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (710002b) 99.66% compared to head (9df238d) 99.67%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #296   +/-   ##
========================================
  Coverage    99.66%   99.67%           
========================================
  Files           96       96           
  Lines         1207     1215    +8     
  Branches       111      114    +3     
========================================
+ Hits          1203     1211    +8     
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nils-a
Copy link
Contributor

nils-a commented Jan 16, 2024

@stehlih looks good. 👍

Could you please rebase this PR to the current develop branch?

@nils-a nils-a self-requested a review January 16, 2024 14:45
@nils-a nils-a added the feature New feature or request label Jan 16, 2024
@nils-a nils-a modified the milestones: vNext, 4.1.0 Jan 16, 2024
@nils-a nils-a enabled auto-merge January 16, 2024 23:37
Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for getting this done! 👍

@nils-a nils-a merged commit b3f58d2 into cake-contrib:develop Jan 16, 2024
8 checks passed
cake-contrib-bot pushed a commit that referenced this pull request Jan 16, 2024
Merge pull request #296 from stehlih/develop

Add more compression options (DictionarySize, SortFilesByType)
@nils-a
Copy link
Contributor

nils-a commented Jan 17, 2024

@all-contributors please add @stehlih for code.

Copy link
Contributor

@nils-a

I've put up a pull request to add @stehlih! 🎉

@cake-contrib-bot
Copy link

🎉 This issue has been resolved in version 4.1.0 🎉
The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants