-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-356) Get work items from build #357
(GH-356) Get work items from build #357
Conversation
a15d6b6
to
293f55f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
293f55f
to
e3b7ed9
Compare
This feature (Returning WorkItems) will be added afterwards. |
e3b7ed9
to
77ea2a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit enhances work item aliases. Can we please keep this PR focus on returning work items of a build and move enhancements to work item aliases to separate PRs
ab910d9
to
77ea2a6
Compare
@pascalberger I removed the last commit |
@twenzel If there will be a method to return work items, what would be the advantage in also having a |
It would be useful when you need to load any work items. The user might have an other source of work item ids than the build. |
@pascalberger I can implement the Build.GetWorkItems method after the PR #364 was merged due to some changes on the WorkItem constructor. |
Sorry, I still don't get it. When you read work items from somewhere else I don't see how it relates to reading work items from builds. |
0b26994
to
d644cdc
Compare
d644cdc
to
1903650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside some smaller typos
@twenzel your changes have been merged, thanks for your contribution 👍 |
Returns a list with work item ids associated with the build.
Fixes #356