Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-356) Get work items from build #357

Merged
merged 6 commits into from
Sep 30, 2022

Conversation

twenzel
Copy link
Contributor

@twenzel twenzel commented Sep 24, 2022

Returns a list with work item ids associated with the build.
Fixes #356

@pascalberger pascalberger changed the title Get work item ids from build (GH-356) Get work item ids from build Sep 24, 2022
@twenzel twenzel force-pushed the feature/GetWorkItemIds branch from a15d6b6 to 293f55f Compare September 24, 2022 17:32
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twenzel Thank you very much for the pull request 👍

With #361 I'm wondering if we should return a list of AzureDevOpsWorkItem instances instead of IDs?

@twenzel twenzel force-pushed the feature/GetWorkItemIds branch from 293f55f to e3b7ed9 Compare September 24, 2022 18:49
@twenzel
Copy link
Contributor Author

twenzel commented Sep 24, 2022

This feature (Returning WorkItems) will be added afterwards.

@twenzel twenzel force-pushed the feature/GetWorkItemIds branch from e3b7ed9 to 77ea2a6 Compare September 24, 2022 21:45
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit enhances work item aliases. Can we please keep this PR focus on returning work items of a build and move enhancements to work item aliases to separate PRs

@twenzel twenzel force-pushed the feature/GetWorkItemIds branch from ab910d9 to 77ea2a6 Compare September 25, 2022 20:22
@twenzel
Copy link
Contributor Author

twenzel commented Sep 25, 2022

@pascalberger I removed the last commit

@pascalberger
Copy link
Member

pascalberger commented Sep 26, 2022

This feature (Returning WorkItems) will be added afterwards.

@twenzel If there will be a method to return work items, what would be the advantage in also having a GetWorkItemIds method?

@twenzel
Copy link
Contributor Author

twenzel commented Sep 26, 2022

@twenzel If there will be a method to return work items, what would be the advantage in also having a GetWorkItemIds method?

It would be useful when you need to load any work items. The user might have an other source of work item ids than the build.
This is just the start of having work item tracking functionality in Cake.

@twenzel
Copy link
Contributor Author

twenzel commented Sep 26, 2022

@pascalberger I can implement the Build.GetWorkItems method after the PR #364 was merged due to some changes on the WorkItem constructor.

@pascalberger
Copy link
Member

@twenzel If there will be a method to return work items, what would be the advantage in also having a GetWorkItemIds method?

It would be useful when you need to load any work items. The user might have an other source of work item ids than the build. This is just the start of having work item tracking functionality in Cake.

Sorry, I still don't get it. When you read work items from somewhere else I don't see how it relates to reading work items from builds.

@twenzel twenzel force-pushed the feature/GetWorkItemIds branch from d644cdc to 1903650 Compare September 27, 2022 06:17
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside some smaller typos

src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuild.cs Outdated Show resolved Hide resolved
src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuild.cs Outdated Show resolved Hide resolved
src/Cake.AzureDevOps/AzureDevOpsAliases.Pipelines.cs Outdated Show resolved Hide resolved
@pascalberger pascalberger changed the title (GH-356) Get work item ids from build (GH-356) Get work items from build Sep 30, 2022
@pascalberger pascalberger enabled auto-merge (squash) September 30, 2022 18:13
@pascalberger pascalberger merged commit 24c27e6 into cake-contrib:develop Sep 30, 2022
@pascalberger
Copy link
Member

@twenzel your changes have been merged, thanks for your contribution 👍

@twenzel twenzel deleted the feature/GetWorkItemIds branch September 30, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to get work items from a build
2 participants