Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-116) updated the calculation for TFM #125

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Mar 15, 2021

This is mainly a restructured calculation of the
project type (addin/module/recipe) and a small
change to the default TFM.

fixes #116

This is mainly a restructured calculation of the
project type (addin/module/recipe) and a small
change to the default TFM.
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #125 (6cb8635) into develop (0d5f70c) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
+ Coverage    90.92%   91.60%   +0.67%     
===========================================
  Files           15       16       +1     
  Lines          507      548      +41     
  Branches        77       80       +3     
===========================================
+ Hits           461      502      +41     
  Misses          28       28              
  Partials        18       18              
Impacted Files Coverage Δ
src/Tasks/CakeProjectType.cs 100.00% <100.00%> (ø)
src/Tasks/CalculateProjectType.cs 100.00% <100.00%> (ø)
src/Tasks/RecommendedCakeVersion.cs 100.00% <100.00%> (ø)
src/Tasks/RequiredFileEditorconfig.cs 100.00% <100.00%> (ø)
src/Tasks/RequiredFileStylecopJson.cs 96.42% <100.00%> (ø)
src/Tasks/RequiredReferences.cs 100.00% <100.00%> (ø)
src/Tasks/TargetFrameworkVersions.cs 92.25% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5f70c...505ae01. Read the comment docs.

@nils-a nils-a merged commit d597e00 into cake-contrib:develop Mar 16, 2021
cake-contrib-bot pushed a commit that referenced this pull request Mar 16, 2021
Merge pull request #125 from nils-a/feature/GH-116

(GH-116) updated the calculation for TFM
@nils-a nils-a deleted the feature/GH-116 branch March 16, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the calculation of the TFM for Cake addins
1 participant