4 Data modalities, python typings, python testing and CLI, client multithreading for send function #18
Conversation
`poetry.lock` is recommended to be tracked for binary packages to ensure reproducibility, and is more commonly ignored by libraries
Also to prevents random changes in other projects from blocking development
For future use
…yi_out` of `protoc`
Non streaming data modalities
…for ARFlow and testing.
| @@ -12,8 +12,11 @@ | |||
| }, | |||
| "editor.defaultFormatter": "charliermarsh.ruff" | |||
| }, | |||
| "python.analysis.typeCheckingMode": "off", // TODO: Enable strict type checking | |||
| "python.analysis.typeCheckingMode": "strict", | |||
protos/compile.sh
Outdated
| @@ -0,0 +1,9 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
I would like to keep script files in a scripts folder.
There was a problem hiding this comment.
Thanks for the suggestion! I prefer keeping build scripts colocated with their inputs for easier maintenance and to ensure they're always in sync. Do you have any thoughts?
There was a problem hiding this comment.
I don't think there is anything right or wrong about this. I prefer to put scripts in their folders because I can open the folder and immediately know what to do in the command line with the associated files. This works better if the codebase is large, and I'm more used to this way. I don't have a strong preference for this project, we could just align the existing practice.
There was a problem hiding this comment.
Yeah, I'll do that. I don't have a strong preference on this either
There was a problem hiding this comment.
Do we need this file to be included in the git repo?
There was a problem hiding this comment.
Ah yeah, I'll add gitignores for these files. Thank you for the note
There was a problem hiding this comment.
I'm not sure if we want to include the XR simulator assets. It would help us to decide if we can find a reference project.
| // Network, device image, camera intrinsics | ||
| Debug.LogError(e); | ||
| } | ||
| Debug.Log(response.Uid); |
There was a problem hiding this comment.
I think we should not have Debug.Log in our core library. This logging call is slowing down the overall performance quite a bit. Maybe we can set up a verbose parameter or something to enable/disable the logging based on needs.
… builds, gitignore XR simulation files
No description provided.