2.x update stan #681
Closed
2.x update stan #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
commented
Nov 17, 2024
| @@ -50,7 +50,7 @@ class Result implements ResultInterface | |||
| /** | |||
| * Sets the result status, identity, and failure messages | |||
| * | |||
| * @param null|array|\ArrayAccess $data The identity data | |||
| * @param null|array|\ArrayAccess|mixed $data The identity data | |||
There was a problem hiding this comment.
These mixed types needed to be added since we check for this and manually throw an exception. Otherwise phpstan would complain, that the if() cannot be reached.
There was a problem hiding this comment.
Seems like we forgot to add types to this class when updating for 5.x. I would just add proper types to the props/methods and bump the plugin version as required to minor/major.
There was a problem hiding this comment.
We did not miss it, this is 2.x and therefore CakePHP 4
Or would you not update stan of the 2.x version of this plugin?
There was a problem hiding this comment.
I wouldnt. Only cake5 ones IMO.
ADmad
reviewed
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.