[feat] added Search Bar, styled Map, and started on Filters #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsliterallymonique
requested changes
Oct 30, 2024
There was a problem hiding this comment.
The design looks nice. But please make the following changes:
- Use styled components instead of CSSProperties
- import each style individually instead of import * as styles
- Use rem / em instead of pixels -- please check this styling guide for guidance on how best practices.
itsliterallymonique
approved these changes
Oct 31, 2024
ethan-tam33
deleted the
22-chore-style-the-home-page-incl-non-functional-search-bar-+-filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Map/map.tsxSearchBar/index.tsxFilterBar/index.tsxalthough with minor styling errorScreenshots
How to review
Map/map.tsx,SearchBar/*, andFilterBar/*Next steps
FilterBarSearchBarRelevant links
Online sources
Related PRs
CC: @itsliterallymonique