[feat] Direct Search Item Component #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: styling fixes * adjusted favicon and page title * adjusted favicon and page title
…ncl. Proposed COD) (#63) * [chore] added tags, files * [chore] file fixes * [chore] file fixes * [feat] finished status tags * [feat] did tech tags * [chore] rem * [feat] done? * [chore] small fixes * [chore] name change, cod * [feat] proposed styling * [chore] refactoring * [feat] fixed icons * [chore] changed geothermal, small fixes --------- Co-authored-by: Neha <[email protected]>
itsliterallymonique
requested changes
Nov 11, 2024
components/ProjectItem/styles.ts
Outdated
|
|
||
| export const ProjectName = styled.div` | ||
| color: ${COLORS.navy}; | ||
| font-family: ${CoinbaseSans}; |
There was a problem hiding this comment.
delete all the fonts stuff here from line 44-48 (its overriding the settings from texts.ts)
assets/Icons/icons.tsx
Outdated
| @@ -0,0 +1,199 @@ | |||
| export const CheckmarkIcon = () => ( | |||
There was a problem hiding this comment.
I think you should keep a KDM icon folder so all icons are organized into their own folders
| queryDefaultImages, | ||
| queryProjectbyId, | ||
| } from '@/api/supabase/queries/query'; | ||
| import { |
There was a problem hiding this comment.
pull from main + rebase then use the icons that Neha has imported. Check her PR for how she added the colors for the renewable energy technology icons: #63
You can also use the new components she made for renewable energy technology and status (if it works for your sprint -- I am not sure if the fonts / text are the same)
itsliterallymonique
requested changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Screenshots
Screen.Recording.2024-11-10.at.18.32.27.mov
How to review
Next steps
font is not the same as figma for some reason, idk if its my fault or if the fonts in the style sheet isn't working or somethingi fixed the fonts i think but the project size and energy type looks a little darker/thicker than on the figmaneed to change symbol for whether its operational or in progress (rn its just a green dot for everything)fixedRelevant links
Online sources
Related PRs
CC: @itsliterallymonique