[feat] [style] Create and Style Filters Dropdown #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-tam33
changed the title
itsliterallymonique
requested changes
Nov 12, 2024
itsliterallymonique
requested changes
Nov 13, 2024
|
I realized some parts of the Filter component wasn't generalizable, specifically the handlers. I created |
| handleButtonClick={handleButtonClick} | ||
| icon={filter.icon} | ||
| label={filter.label} | ||
| currFilter={filter} |
There was a problem hiding this comment.
what does currFilter do?
components/Filter/styles.ts
Outdated
| import { FilterHeadingUnused } from '@/styles/texts'; | ||
|
|
||
| export const FilterBackgroundStyles = styled.div<{ isActive: boolean }>` | ||
| margin-right: 2%; |
There was a problem hiding this comment.
i think you have to make the changes here and below where I commented. The styling still does not look like josh's figma hi-fis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
FilterBarto be individualMapViewScreencomponentTechnologyDropdowncomponentTechnologyDropdowncomponent to render on top of the "Technology" filter button upon clicking "Technology" filter buttonFilterstype to hold all possible changes from "Status", "Technology", "Project Size", and "Location" filter dropdownsSome relevant stuff I created:
handleButtonClick- a function that takes in a filter and allows for 1. toggling the dropdown bar and 2. any other action we want to implementfilterChangeHandlers- a variable that holds all the handler methods for each filterFilter- a component that will hold all the dropdowns of each filterScreenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @itsliterallymonique