Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error message for phone number length for Log In #156

Merged
merged 49 commits into from
May 17, 2020
Merged

Display error message for phone number length for Log In #156

merged 49 commits into from
May 17, 2020

Conversation

annieyro
Copy link
Collaborator

@annieyro annieyro commented May 13, 2020 •
edited by wangannie
Loading

What's new in this PR

  • Display error for phone number length in LogInScreen (but not password)
  • Refactored it to match the other Auth screens with the inputFields enums
  • Cleaned up some of the comments in the relevant files

As in the other auth screens, the error message can only be triggered in onBlur and removed in onTextChange.
The "universal" error for this screen is now kept in state as this.state.errors.submit.

Branches off #148 because there are some auth-related updates there
Resolves #80

How to review

Play around on LogInScreen - you should be able to trigger the error message. Everything else should behave the same as before.

Relevant Links

Related PRs

#48
branches off #148

Next steps

I asked about this in Slack, but we can remove the clearState function from SignUpScreen given that the Updates.reload() call in the logOut functions make sure we never get taken back to the filled-out forms anymore.

Screenshots

image

https://www.loom.com/share/ddc93a72c72e49508157165f97592134

CC: @wangannie

wangannie and others added 30 commits April 11, 2020 22:20
@wangannie
Added new firebase connection
c7fbb92
@wangannie
Navigation log
6317b4b
@wangannie
Log resource card press
a1feef5
@wangannie
Test logevent on ResourcesScreen
8174a21
@wangannie
Log user id on signup or login
8f262ca
@wangannie
Fiex event messages
6462a3a
@wangannie
Cleanup
87de651
@kennethlien
Lots of issues understanding verifier please help
0b90c65
@kennethlien
gotta scheme
afe451d
@kennethlien
thingy pops up
0755220
@kennethlien
it texts now
0da3a7f
@kennethlien
Rough hopefully functional recaptcha verification
c6cf1aa
@wangannie
Merge branch 'master' of https://github.com/calblueprint/dccentralkit…
a01643d 
…chen into AnnieW/firebase
@wangannie
Merge branch 'master' of https://github.com/calblueprint/dccentralkit…
c757431 
…chen into AnnieW/firebase
@wangannie
Updated setUser to match Sentry
f635387
@wangannie
Updated to setUserProperties
b1f4483
@wangannie
Merge branch 'AnnieW/firebase' of https://github.com/calblueprint/dcc…
a0b6a6a 
…entralkitchen into kenneth/recaptcha
@annieyro
Merge branch 'master' into kenneth/recaptcha
8e17e4e
@annieyro
Remove unused state, rename ref, add explicit modal close call, reord…
a2bf66d 
…er functions
@kennethlien
FINISHED
47f8253
@kennethlien
fixed style and bugs
0fb3b16
@kennethlien
this one
55e4fe2
@wangannie
KeyboardAvoidingView setup
9e540e2
@kennethlien
major bugfix, minor styling
e232096
@kennethlien
debugging!
972db55
@wangannie
Added dismisskeyboard on successful login and signup
7da0099
@kennethlien
removed unused line
a4e005a
@kennethlien
cleaned code
1194c42
@kennethlien
Merge branch 'kenneth/recaptcha' of https://github.com/calblueprint/d…
6125c00 
…ccentralkitchen into kenneth/recaptcha
@kennethlien
cleaned code
e061af5
annieyro and others added 18 commits May 2, 2020 20:06
@annieyro
Merge remote-tracking branch 'origin/master' into kenneth/recaptcha
dec7605
@kennethlien
fixed a proptype error
b329536
@kennethlien
fixed some promise rejections
3d76c2f
@kennethlien
added encryption to reset passwords
b58ab99
@kennethlien
await fixes for logout
430dbd8
@wangannie
Merge branch 'master' of https://github.com/calblueprint/dccentralkit…
6367c15 
…chen into kenneth/settings
@annieyro
Add error handling back during onTextChange. Refactor permissions (le…
7d06c2a 
…ave out of state). Cleanup/rename/etc
@annieyro
Missing peer dependency
b3fc5e4
@annieyro
onTextChange error update edge cases
6b78342
@annieyro
Move duplicate check
a1b840f
@kennethlien
figma
0a62343
@wangannie
Added back line that was lost in earlier PR
71a40c9
@kennethlien
adding reloading and removed back button from success screens
7b50caf
@wangannie
Added location settings, fixed About, cleanup
417643d
@wangannie
Added Updates.reload to all logout functions
619f0c2
@kennethlien
capitalized O in logout
7377130
@annieyro
Refactor login to show error for phone number, cleanup comments
0828343
@annieyro
Cleanup
73fa551
@annieyro annieyro requested a review from wangannie May 13, 2020 09:11
@wangannie wangannie linked an issue May 13, 2020 that may be closed by this pull request
No error message for incorrect phone number length in Login #80
Closed
wangannie
wangannie approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@wangannie wangannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wangannie wangannie changed the base branch from kenneth/settings to master May 17, 2020 20:53
@wangannie wangannie merged commit 717edd7 into master May 17, 2020
@wangannie wangannie deleted the annie/login-error branch May 17, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangannie wangannie wangannie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No error message for incorrect phone number length in Login
3 participants
@annieyro @wangannie @kennethlien