Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier config to use trailing commas; add local workspace settings for VS Code #53

Merged
merged 5 commits into from
Mar 29, 2020

Conversation

annieyro
Copy link
Collaborator

@annieyro annieyro commented Mar 27, 2020

What's new in this PR

  • Changed prettier config file to be .prettierrc so that it's picked up by the VS Code extension
  • Added trailing comma rule
  • Updated the scripts to be better
  • Ran yarn run pretty-all to format all the files we care about
  • Added a local .vscode/settings.json so we can share settings (these override user settings)

Relevant Links

Online sources

Related PRs

How to review

Make sure everything still works

Next steps

Tests Performed, Edge Cases

Screenshots

CC: @anniero98 @wangannie

Copy link
Member

@wangannie wangannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE TRAILING COMMAS 😍

@wangannie wangannie merged commit ed225a3 into master Mar 29, 2020
@annieyro annieyro deleted the annie/update-prettier branch March 30, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants