Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading drawer bug #75

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix loading drawer bug #75

merged 1 commit into from
Apr 8, 2020

Conversation

annieyro
Copy link
Collaborator

@annieyro annieyro commented Apr 6, 2020

What's new in this PR

Fix bug (caused by #48) where loading drawer when logged out would throw Airtable error

Relevant Links

Related PRs

Caused by swapping Airtable calls in #48, and throwing errors. When logged out, AsyncStorage won't have a userId saved, but currently the code will attempt to get a customer back from Airtable using the null returned.

How to review

Next steps

Tests Performed, Edge Cases

Screenshots

image
^ should no longer appear

CC: @wangannie

@annieyro annieyro added the bug Something isn't working label Apr 6, 2020
@annieyro annieyro requested a review from tommypoa April 6, 2020 05:13
@annieyro annieyro self-assigned this Apr 6, 2020
Copy link
Contributor

@tommypoa tommypoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! One thing - think this fix should be applied to RewardsScreen as well? Clicking the rewards tab in the drawer as a guest would throw the same Airtable error for me when I tested. If possible you could add into this PR or create another one :))

@annieyro annieyro merged commit 4c54dd0 into master Apr 8, 2020
@annieyro annieyro deleted the annie/fix-drawerloading branch April 8, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants