[DRAFT PR] Emily/genre carousels #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this [DRAFT] PR
I added a genre query function that pulls a database function from supabase called get_subgenres. I created a component called LandingCard, which should reflect each individual genre card that is displayed in the genre carousel. I also created a parent component called LandingScrollView which should be able to take in a LandingCard as a prop and display it. I am having trouble figuring out the data flow because LandingCard also takes in component props, and I am not sure whether these props should be passed all the day down from LandingScrollView all the way down to Landing Card.
Relevant Links
Notion Sprint Task
Online sources
Related PRs
How to review
Next steps
Tests Performed, Edge Cases
Screenshots
CC: @akshaynthakur