Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Dismiss keyboard when tapping outside textbox #68

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jjstnlee
Copy link
Contributor

What's new in this PR

Added ability to dismiss keyboard when tapping screen.

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/bug-Dismiss-keyboard-when-tapping-outside-textbox-dca3413f901846dbae3168e48e8982b6

Online sources

Related PRs

How to review

Next steps

Tests Performed, Edge Cases

Screenshots

CC: @adityapawar1

@jjstnlee jjstnlee requested a review from adityapawar1 March 15, 2024 04:30
Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adityapawar1 adityapawar1 merged commit 0250b59 into main Mar 15, 2024
2 checks passed
@adityapawar1 adityapawar1 deleted the justin/dismiss-keyboard branch March 15, 2024 04:58
adityapawar1 added a commit that referenced this pull request Mar 27, 2024
* Added ability to go to verification screen from signup and forgot password

* Fixed error with verification screen after forgetting password

* Changed new password screen so that password requirements show even when the user hasn't inputted a new password yet

* Fix small bugs in sign up and create password

* Added ability to dismiss keyboard when tapping screen (#68)

* [save] Database schema changes for saving stories (#61)

* accidently forgot to branch

* fethUserSavedStories function created

* categories created

* added method to delete row

* favorites and reading list global variables set

* PR changes

* Add testcard

* Finish testing schema changes

* Run prettier

* Remove testcard from home

* Clean up code

* Run prettier

---------

Co-authored-by: Marcos Hernandez <[email protected]>
Co-authored-by: Aditya Pawar <[email protected]>

* Fix keyboard dismiss bug on story scroll (#70)

* Fix keyboard dismiss bug on story scroll

* Remove comments

* Fix return statement in fetch (#72)

* Fix return statement in fetch

* Batch rpc call

* Run prettier

* Added content width prop to RenderHTML (#71)

* [auth] Date picker crossplatform (#69)

* added date picker button, no styling yet

* working on style datepicker

* working on datePicker

* new datePicker library

* testing on android

* finished datePicker

* changed small bugs

* Fix date picker bugs

* Revert set state

---------

Co-authored-by: Kyle Ramachandran <[email protected]>
Co-authored-by: Aditya Pawar <[email protected]>

* Fixed requested changes

* Add eas.json to gitignore

---------

Co-authored-by: Aditya Pawar <[email protected]>
Co-authored-by: Marcoss28 <[email protected]>
Co-authored-by: Marcos Hernandez <[email protected]>
Co-authored-by: Aditya Pawar <[email protected]>
Co-authored-by: surajr10 <[email protected]>
Co-authored-by: Kyle Ramachandran <[email protected]>
Co-authored-by: Kyle Ramachandran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants