Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buyankhuu/footer #22

Closed
wants to merge 12 commits into from
Closed

Buyankhuu/footer #22

wants to merge 12 commits into from

Conversation

BuyankhuuTsCAl
Copy link
Collaborator

What's new in this PR

Description

  • Created a popup using toasty for the logout button which will redirect the user to the login screen.
  • Footer for all the pages was created
  • New components:
  • Footer: the entirety of the footer
  • location: the small div with the text of each location that Shanti has
  • added the logo to the login screen and got rid of the yellow box

Screenshots

https://www.loom.com/share/58a7630a1d24461597a765d1afb769ac?sid=f2700b80-fcc4-4901-b9bb-6ff3e24f70b2

How to review

Order: Component/Location -> Component/Footer -> style/component -> Profile/page -> Profile/style

Testing:

  • go to localhost
  • go to each page and scroll to the bottom to see the footer
  • navigate to localhost/profile
  • press logout -> popout shows up -> send user to login page

Next steps

next step: see if design of footer changes/ popup

Relevant Links

Online sources

Related PRs

🛍 CC: @EthanAuyeung

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shanti-project ❌ Failed (Inspect) Nov 2, 2023 9:23pm

Copy link
Collaborator

@EthanAuyeung EthanAuyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge once we go over how to review pr's and you get another approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants