Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethan/profile page #39

Closed
wants to merge 4 commits into from
Closed

Ethan/profile page #39

wants to merge 4 commits into from

Conversation

EthanAuyeung
Copy link
Collaborator

@EthanAuyeung EthanAuyeung commented Jan 24, 2024

What's new in this PR

Description

Built out the Profile Page. Created a new query fetchUserAddress to get the User's Address based on their UUID. Also updated the Nav Bar to allow conditional navigation to different profile pages based on if a user has delivery enabled.

Screenshots

Screenshot 2024-01-24 at 1 39 21 PM Screenshot 2024-01-24 at 3 37 54 PM

How to review

Clone this branch and run npm run dev and play around with different accounts.

Next steps

Waiting for @kevinjcai to finish Order History queries to implement Order History Section on the Profile Screen.

Relevant Links

Online sources

Related PRs

🛍 CC: @EthanAuyeung

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shanti-project ❌ Failed (Inspect) Jan 24, 2024 11:39pm

@EthanAuyeung
Copy link
Collaborator Author

Having some git issues where not all commits are showing.

@BuyankhuuTsCAl
Copy link
Collaborator

Hey Ethan,

Great work! A couple of things that I am noticing from the screenshot are that the

  • the navbar is missing
  • the text for the favorites is not aligned properly as you can see the text from the screenshots on both rows starts at different spots.
  • the product text should be left aligned instead of center aligned.
  • the heart might be a little too big.
  • both of the view all arrows have underlined text for the view all text
  • The spacing is looking a little funny.
  • try to align the section headers and the view all arrows together.
  • might be wrong but the text's styling looks a little off. Please make sure that you are using the right text style.

This is a really hard task! Let me know when you are done fixing the issues that are mentioned above! Thank you for your hard work and let me know if you need help with the front end. Still haven't checked the backend or code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants