Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch for profile screen cause of git issues #40

Closed
wants to merge 4 commits into from

Conversation

EthanAuyeung
Copy link
Collaborator

@EthanAuyeung EthanAuyeung commented Jan 31, 2024

What's new in this PR

Description

Built out the Profile Page. Created a new query fetchUserAddress to get the User's Address based on their UUID. Also updated the Nav Bar to allow conditional navigation to different profile pages based on if a user has delivery enabled.

Screenshots

Screenshots make it look weird because had to zoom out to show everything, recommend running the branch locally and checking it out.

Screenshot 2024-01-31 at 12 16 26 PM Screenshot 2024-01-24 at 3 37 54 PM

How to review

Clone this branch and run npm run dev and play around with different accounts.

Next steps

Waiting for @kevinjcai to finish Order History queries to implement Order History Section on the Profile Screen.

Relevant Links

Online sources

Related PRs

🛍 CC: @EthanAuyeung

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shanti-project ❌ Failed (Inspect) Feb 18, 2024 7:37am

@BuyankhuuTsCAl
Copy link
Collaborator

BuyankhuuTsCAl commented Feb 13, 2024

@EthanAuyeung
just looked at your sprint and there are still some issues that I pointed out last time that still need to be fixed. I will list the ones I see right away, but it might be helpful to look at them yourself too.

Front end wise:

  • Spacing is hella off between the sections -> try to make the spacing somewhat even on both sides and make account detail wider
  • the viewAll text is not aligned w/ the section header
  • can you double check text style because it looks a little off
  • navBar got rendered but the icons are white for some reason? -> even on the storefront page
  • profile screen ideally should fit within one screen without me having to scroll
  • the issue about spacing with products with longer names and how it impacts the surrounding items spacing

Backend wise:

  • can you separate the different sections into different functions that get called within the main function

do you think you'll be able to collapse the two files for the profile screen into one and just have two different functions that will render the difference in user information? At the moment, I have a couple of pages that will go back to profile screen and I feel like it might be easier for those file to just be sent to one file.
at the moment, there seems to be a lot of bugs but I know you got this! Thank you for taking such a big sprint 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants