MicroBitAccelerometer: do not overwrite component id #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the class variable `id` (intended for use by the event subsystem) was accidently overwritten by commit d386ce2. This commit simply removes the assignment as it is not used by any code within this class.
|
This seems to be no longer an issue on recent tagged revisions. Either way the |
Amerlander
pushed a commit
that referenced
this pull request
Sep 28, 2019
* Movd MICROBIT_MODE_* defines to MicroBitConfig.h * Search for embedded source and remove magic * Fixed memcpy * Change offset order * Fixed memcpy for data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the class variable
id(intended for use by the eventsubsystem) was accidently overwritten by commit d386ce2.
This commit simply removes the assignment as it is not used by any code
within this class.