-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow node params on links #736
base: main
Are you sure you want to change the base?
Allow node params on links #736
Conversation
@@ -154,7 +155,7 @@ def node_dict(self, techs_incl_inheritance: AttrDict) -> AttrDict: | |||
techs_incl_inheritance[tech].get("base_tech", None) | |||
== "transmission" | |||
): | |||
self._raise_error( | |||
self._raise_warning( | |||
"Cannot define transmission technology data over the `nodes` dimension" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we change the message to something like this?
"Trying to define transmission technology data over the
nodes dimension. Be sure that you know what you are doing."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want a more descriptive message, stating the possible error that this might create.
Thanks for the contribution @jnnr. My only concern is that this was in there for a reason. If you define transmission data at a node in YAML, what happens with this change? It would require some tests to check for what happens. |
Thanks for your comments, @brynpickering and @irm-codebase. Apparently, we need to first better understand how link data is treated in preprocessing to understand the scenarios of failure we are opening up. I will take some time with to study this with @irm-codebase at the whiteboard and come back to this soon. |
Fixes the following issue:
I am not allowed to set a constraint on
flow_out
of transmission links. I will get this error:I am trying to provide the model with a data table like this:
And a constraint like this:
Summary of changes in this pull request
I convert the error message into a warning.
Reviewer checklist