Skip to content

Commit

Permalink
fix: use 'all' for fabric components codegen config (#715)
Browse files Browse the repository at this point in the history
currently codegen doesn't generate all required files such as
`Android.mk`, `CMakeLists.txt` etc. for fabric when type is set to
`components`. so we use `all` for now until this bug is fixed.

closes #661
  • Loading branch information
satya164 authored Dec 4, 2024
1 parent 34b1f80 commit 219055b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<% if (project.arch !== 'legacy') { -%>
"codegenConfig": {
"name": "RN<%- project.name -%><%- project.view ? 'View': '' -%>Spec",
"type": <%- project.view ? '"components"': '"modules"' %>,
"type": <%- project.view ? '"all"': '"modules"' %>,
"jsSrcsDir": "src"
},
<% } -%>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
},
"codegenConfig": {
"name": "RN<%- project.name -%><%- project.view ? 'View': '' -%>Spec",
"type": "<%- project.view ? 'components': 'modules' -%>",
"type": "<%- project.view ? 'all': 'modules' -%>",
"jsSrcsDir": "src",
"outputDir": {
"ios": "ios/generated",
Expand All @@ -209,7 +209,7 @@
<% if (example === 'vanilla') { -%>
},
"includesGeneratedCode": true
<% } else { -%>
<% } else { -%>
}
<% } -%>
<% } -%>
Expand Down

0 comments on commit 219055b

Please sign in to comment.